fix: Attributes in timeouts are erroneously reversed #1804
Conversation
The timeouts {} attributes are reversed.
…outs
Fix reversed timeouts {} attributes
qingvincentyin
changed the title
qingvincentyin
changed the title
qingvincentyin
changed the title
qingvincentyin
changed the title
|
is this change necessary? |
|
Are you asking me? If so, why not? The original code obviously had the 2 attributes transposed. |
|
ooooh, I see it now. Sorry, the information provided in the PR was not clear |
There was a problem hiding this comment.
@antonbabenko should be go with or without the order change
thanks for the catch and fix @qingvincentyin
|
I agree that it should be in order like CRUD. Merging now. |
### [18.2.2](v18.2.1...v18.2.2) (2022-01-22) ### Bug Fixes * Attributes in timeouts are erroneously reversed ([#1804](#1804)) ([f8fe584](f8fe584))
|
This PR is included in version 18.2.2 🎉 |
### [18.2.2](terraform-aws-modules/terraform-aws-eks@v18.2.1...v18.2.2) (2022-01-22) ### Bug Fixes * Attributes in timeouts are erroneously reversed ([#1804](terraform-aws-modules/terraform-aws-eks#1804)) ([b1bb32b](terraform-aws-modules/terraform-aws-eks@b1bb32b))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
The 2 lines in my proposed change were erroneously reversed in your original code.