Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable max-pods-per-node #1621

Closed
davidgiga1993 opened this issue Oct 6, 2021 · 5 comments · Fixed by #1667
Closed

Customizable max-pods-per-node #1621

davidgiga1993 opened this issue Oct 6, 2021 · 5 comments · Fixed by #1667

Comments

@davidgiga1993
Copy link

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

Yes, when using another CNI for example canico the default limit doesn't make sense anymore and should be configurable

Describe the solution you'd like.

Make the max pods per node a parameter

Describe alternatives you've considered.

Not using terraform, but it would be a pretty big step back

Additional context

Same request in the aws provider repo: hashicorp/terraform-provider-aws#20115

@daroga0002
Copy link
Contributor

This will be addressed in #1577 when it will be merged

@daroga0002 daroga0002 added the wip label Oct 6, 2021
@stevehipwell
Copy link
Contributor

As #1577 has been merged this can probably be closed? It's worth noting that this was always possible via custom userdata, but it's much easier now.

mng = {
  ...

  bootstrap_env = {
    USE_MAX_PODS="false"
  }

  kubelet_extra_args = "--max-pods 110"

  ...
}

@daroga0002
Copy link
Contributor

I opened #1667 to update one example

@antonbabenko
Copy link
Member

This issue has been resolved in version 17.24.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants