fix: Default root_volume_type must be gp2

[barryib]

PR o'clock

Description

Please explain the changes you made here and link to any relevant issues.

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[nauxliu]

Just curious, why the default must be gp2?

[barryib]

Just curious, why the default must be gp2?

If I remember, it's because launch configuration doesn’t support it. I'll go with gp3 when we drop LC support (soon).

[nauxliu]

Just curious, why the default must be gp2?

If I remember, it's because launch configuration doesn’t support it. I'll with gp3 when we'll drop LC support (soon).

Thanks for the explanation

[yalimpop]

On a global scale this commit causes AWS billing to increase for everyone using this module :)

[ivandir]

@barryib Is there plan to support Launch Template instead? See https://forums.aws.amazon.com/thread.jspa?messageID=969349

[ivandir]

I agree with @yalimpop this module will become undesirable in the future with only GP2 support.

[bryantbiggs]

@ivandir this issue is quite old and the latest version of the module provides support for any EBS type desired

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.