Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tags on additional IAM resources like IAM policies #1321

Conversation

ivan-sukhomlyn
Copy link
Contributor

@ivan-sukhomlyn ivan-sukhomlyn commented Apr 26, 2021

PR o'clock

Description

Issue - 1320

  1. Support AWS tags on the following IAM resources
  • aws_iam_policy
  • aws_iam_instance_profile
  • aws_iam_openid_connect_provider
  1. Bump required AWS provider version to the 3.35.0

Checklist

@ivan-sukhomlyn ivan-sukhomlyn force-pushed the issue_1320_tags_on_IAM_resources branch from 0dc3c61 to 2ab6286 Compare April 26, 2021 21:41
@barryib barryib changed the title improvement: add tags on additional IAM resources like policy feat: Add tags on additional IAM resources like IAM policies May 4, 2021
@barryib barryib merged commit c12c186 into terraform-aws-modules:master May 4, 2021
@barryib
Copy link
Member

barryib commented May 4, 2021

Thanks @ivan-sukhomlyn

@ivan-sukhomlyn ivan-sukhomlyn deleted the issue_1320_tags_on_IAM_resources branch May 5, 2021 15:02
@ivan-sukhomlyn
Copy link
Contributor Author

@barryib Thank you for review and including these changes in the release.

barryib pushed a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Jun 1, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants