Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for specifying elastic inference accelerator #1176

Merged
merged 4 commits into from
Apr 19, 2021

Conversation

rucha3
Copy link
Contributor

@rucha3 rucha3 commented Jan 6, 2021

PR o'clock

Description

This PR implements feature requested in #1175

It allows adding an elastic inference accelerator type to worker groups.
Example usage:

worker_groups_launch_template = [
   ...
    {
      name                          = "worker-group"
      instance_type                 = "c5.large"
      asg_desired_capacity          = 1
      public_ip                     = true
      elastic_inference_accelerator = "eia2.medium"
    },
   ...
  ]

Resolves #1175

Checklist

@rucha3
Copy link
Contributor Author

rucha3 commented Jan 21, 2021

Hi @barryib . Would it be possible to get a review on this PR?

@barryib barryib merged commit 26d40d2 into terraform-aws-modules:master Apr 19, 2021
barryib pushed a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Elastic Inference Accelerator for worker groups
2 participants