Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change instance type from t2 to t3 in examples #1169

Merged

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Dec 31, 2020

PR o'clock

Description

The t2 instance type isn't available in newer regions such as eu-north-1. Therefore the examples using t2 will fail in this region.

Available instance types can be verified with:
aws ec2 describe-instance-type-offerings --location-type "region" --region eu-north-1 | jq '.InstanceTypeOfferings[].InstanceType | select(startswith("t"))'

Checklist

The t2 instance type isn't available in newer regions such as
eu-north-1. Therefore the examples using t2 will fail in this region.
@barryib barryib changed the title fix: Change example instance type from t2 to t3. docs: Change instance type from t2 to t3 in examples Jan 28, 2021
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oscr for your contribution.

@barryib barryib merged commit 357e647 into terraform-aws-modules:master Jan 28, 2021
@oscr oscr deleted the change-example-instance-type branch January 29, 2021 08:29
ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Apr 16, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants