Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AmazonEKSVPCResourceController to cluster policy to be able to set AWS Security Groups for pod #1011

Conversation

toneill818
Copy link
Contributor

PR o'clock

Description

AWS recently added the ability to assign security groups to pods, more info about this can be found here. This new feature requires an additional policy attached to the cluster role.

Checklist

@toneill818 toneill818 changed the title Added AmazonEKSVPCResourceController To Cluster Policy improvement: Added AmazonEKSVPCResourceController To Cluster Policy Sep 15, 2020
Copy link

@m-barthelemy m-barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This accomplishes exactly what is requested in the official AWS doc, nothing less, nothing more.

@barryib barryib self-assigned this Sep 22, 2020
@barryib barryib changed the title improvement: Added AmazonEKSVPCResourceController To Cluster Policy feat: Add AmazonEKSVPCResourceController to cluster policy Oct 4, 2020
@barryib
Copy link
Member

barryib commented Oct 4, 2020

Thanks @toneill818 for your contribution.

@barryib barryib changed the title feat: Add AmazonEKSVPCResourceController to cluster policy feat: Add AmazonEKSVPCResourceController to cluster policy to be able to set AWS Security Groups for pod Oct 4, 2020
@barryib barryib merged commit 31ad394 into terraform-aws-modules:master Oct 4, 2020
@barryib barryib mentioned this pull request Oct 4, 2020
4 tasks
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants