Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for volumes in task definitions #70

Closed
compdemo0908 opened this issue Sep 20, 2022 · 14 comments · Fixed by #76
Closed

Add support for volumes in task definitions #70

compdemo0908 opened this issue Sep 20, 2022 · 14 comments · Fixed by #76

Comments

@compdemo0908
Copy link

compdemo0908 commented Sep 20, 2022

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.
- Yes ✅: please list the AWS provider version which introduced this functionality
aws_ecs_task_definition add argument for volumes:
https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#3450-june-10-2021

Is your request related to a problem? Please describe.

Create services with task definitions that support volumes, i.e. EFS or FSx:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_task_definition#volume

when finishing the TODO list for the service submodule:
https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/modules/service

Describe the solution you'd like.

Create a module input to support volume arguments in the aws_ecs_task_definition that's already in the TODO list of the Read.Me

Describe alternatives you've considered.

This third party module:
https://github.com/techservicesillinois/terraform-aws-ecs-service#network_configuration

Additional context

Third party module has too many co-dependencies and it's almost sunset. For example, when creating a service with a LB the Default Forward Rule can't be used but a Host Condition is required. Adding un-necessary complexity.

@antonbabenko
Copy link
Member

Currently, this module is under active development, and such feature request is already among TODO's here - https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/modules/service#todo

@bryantbiggs Please correct me if I am wrong.

@bryantbiggs
Copy link
Member

correct - we will have support for this shortly

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This issue was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this as completed Nov 2, 2022
@gruckion
Copy link

gruckion commented Nov 7, 2022

This ticket shouldn't be closed as it's not yet resolved.

@bryantbiggs bryantbiggs reopened this Nov 7, 2022
@bryantbiggs bryantbiggs added wip and removed stale labels Nov 7, 2022
@vishwa-trulioo
Copy link

I noticed that there is a PR for this. When will this be rolled out?

@bryantbiggs
Copy link
Member

soon - we are testing the changes against known patterns and examples first. It just takes some time but it is actively being worked on

@ahummel25
Copy link

ref https://github.com/terraform-aws-modules/terraform-aws-ecs/compare/master...bryantbiggs:terraform-aws-ecs:feat/service?expand=1

When this PR is created and subsequently rolled out, will this allow creation of the actual ECS service and task definition? Or what all functionality will be included there?

@bryantbiggs
Copy link
Member

Yes - this module should cover all of the different facets provided by ECS today (as supported by the Terraform provider of course)

@compdemo0908
Copy link
Author

Thanks so much for actively working on this!

@victorcechinel
Copy link

Thanks so much for actively working on this!

@antonbabenko
Copy link
Member

This issue has been resolved in version 5.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants