-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for volumes in task definitions #70
Comments
Currently, this module is under active development, and such feature request is already among TODO's here - https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/modules/service#todo @bryantbiggs Please correct me if I am wrong. |
correct - we will have support for this shortly |
This issue has been automatically marked as stale because it has been open 30 days |
This issue was automatically closed because of stale in 10 days |
This ticket shouldn't be closed as it's not yet resolved. |
I noticed that there is a PR for this. When will this be rolled out? |
soon - we are testing the changes against known patterns and examples first. It just takes some time but it is actively being worked on |
When this PR is created and subsequently rolled out, will this allow creation of the actual ECS service and task definition? Or what all functionality will be included there? |
Yes - this module should cover all of the different facets provided by ECS today (as supported by the Terraform provider of course) |
Thanks so much for actively working on this! |
Thanks so much for actively working on this! |
This issue has been resolved in version 5.0.0 🎉 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.
- Yes ✅: please list the AWS provider version which introduced this functionality
aws_ecs_task_definition add argument for volumes:
https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#3450-june-10-2021
Is your request related to a problem? Please describe.
Create services with task definitions that support volumes, i.e. EFS or FSx:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_task_definition#volume
when finishing the TODO list for the service submodule:
https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/modules/service
Describe the solution you'd like.
Create a module input to support volume arguments in the aws_ecs_task_definition that's already in the TODO list of the Read.Me
Describe alternatives you've considered.
This third party module:
https://github.com/techservicesillinois/terraform-aws-ecs-service#network_configuration
Additional context
Third party module has too many co-dependencies and it's almost sunset. For example, when creating a service with a LB the Default Forward Rule can't be used but a Host Condition is required. Adding un-necessary complexity.
The text was updated successfully, but these errors were encountered: