Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the example workable #23

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

ozbillwang
Copy link
Contributor

Description

with original setting, nat gateway is disable, we have no chance to know why the ec2 instance can't be added to ECS cluster automatically, because when the ec2 instance started, it has a yum update job failed (no internet access, blocked and failed)

second, the default autoscaling group is set to 0 for desired size, it makes me crazy why I can't see it in ECS directly.

This PR fixed both problems

Motivation and Context

This PR fixed both problems described above.

Breaking Changes

No, it is example change.

How Has This Been Tested?

terraform init
terraform plan
terraform apply

@ozbillwang ozbillwang changed the title make the example workable. fix: make the example workable. Jun 23, 2020
@ozbillwang
Copy link
Contributor Author

ozbillwang commented Jun 23, 2020

@antonbabenko

If nat gateway is disable as original code, we are very hard to troubleshooting the issue, because the ec2 instance has no keypair that you can use to ssh, and it is in private subnet (that means you need start up a jump box in public subnets)

So please think about the way when a newbie who need run your code, will be stuck there forever.

for me, even I worked on ECS for a while, it still takes me more than 1 hour to figure it out.

@antonbabenko antonbabenko changed the title fix: make the example workable. fix: make the example workable Jun 23, 2020
@antonbabenko antonbabenko merged commit b794960 into terraform-aws-modules:master Jun 23, 2020
@antonbabenko
Copy link
Member

Ok, no problems, I merged this one.

v2.2.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants