Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added IAM role id to outputs #13

Merged
merged 4 commits into from
Oct 6, 2020

Conversation

frimik
Copy link
Contributor

@frimik frimik commented Nov 22, 2019

Description

Slightly increases the versatility of the module. By including the iam role id in outputs, one can add other policy attachments to the iam role outside of the module itself.

@mateuszkwiatkowski
Copy link

mateuszkwiatkowski commented Jul 27, 2020

Is anything blocking this change from being merged? It would be nice to support SSM out of the box or at least have the iam role id available in outputs.

@mateuszkwiatkowski
Copy link

Heads-up @antonbabenko

@antonbabenko antonbabenko changed the title outputs: iam role id feat: Added IAM role id to outputs Oct 6, 2020
@antonbabenko antonbabenko merged commit c71bcaa into terraform-aws-modules:master Oct 6, 2020
@antonbabenko
Copy link
Member

Thanks @frimik for this PR.

v2.4.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants