Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the permission for the public ecr #7

Merged

Conversation

niroz89
Copy link
Contributor

@niroz89 niroz89 commented Jun 24, 2022

Description

Fix the ECR Permission policy for the public ECR repo.

Motivation and Context

Current permission policy created for public ecr repo are wrong.

Breaking Changes

No breaking changes

image

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@niroz89 niroz89 changed the title Fix the permission for the public ecr fix: the permission for the public ecr Jun 24, 2022
@niroz89 niroz89 changed the title fix: the permission for the public ecr fix: Update the permission for the public ecr Jun 24, 2022
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix @niroz89 !

@bryantbiggs bryantbiggs merged commit 70f3252 into terraform-aws-modules:master Jun 26, 2022
antonbabenko pushed a commit that referenced this pull request Jun 26, 2022
### [1.3.1](v1.3.0...v1.3.1) (2022-06-26)

### Bug Fixes

* Update the permission for the public ecr ([#7](#7)) ([70f3252](70f3252))
@antonbabenko
Copy link
Member

This PR is included in version 1.3.1 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
@niroz89 niroz89 deleted the fix-public-ecr-perm branch January 2, 2023 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants