feat: Add wrapper module and pre-commit hook #3
Conversation
There was a problem hiding this comment.
Great to see that you are using Terragrunt with this pattern (wrapper) also.
The PR looks good but examples in wrappers/README.md should be updated. Those examples are generic and currently only use the s3-bucket module. It is not very easy to make them really dynamic for each module using terraform_wrapper_module_for_each hook.
.github/workflows/pre-commit.yml
Outdated
| sudo tar -xzf hcledit.tgz -C /usr/bin/ hcledit | ||
| rm -f hcledit.tgz 2> /dev/null | ||
| hcledit version | ||
|
|
||
| - name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }} | ||
| uses: clowdhaus/terraform-composite-actions/[email protected] |
There was a problem hiding this comment.
please bump this
| uses: clowdhaus/terraform-composite-actions/pre-commit@v1.3.0 | |
| uses: clowdhaus/terraform-composite-actions/pre-commit@v1.5.0 |
| sudo tar -xzf hcledit.tgz -C /usr/bin/ hcledit | ||
| rm -f hcledit.tgz 2> /dev/null | ||
| hcledit version | ||
|
|
||
| - name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }} | ||
| uses: clowdhaus/terraform-composite-actions/[email protected] | ||
| with: |
There was a problem hiding this comment.
add below the with: statement
install-hcledit: trueYou can see this for an example https://github.com/clowdhaus/terraform-composite-actions/blob/f6fef5a9cf9e43634536f5712cae4de8d28b8823/.github/workflows/pre-commit.yml#L80
.github/workflows/pre-commit.yml
Outdated
| @@ -71,6 +71,14 @@ jobs: | |||
| id: minMax | |||
| uses: clowdhaus/[email protected] | |||
|
|
|||
| - name: Install hcledit (for terraform_wrapper_module_for_each hook) | |||
There was a problem hiding this comment.
with the changes to the version of the pre-commit action and adding install-hcledit: true we can remove this new step
## [1.2.0](v1.1.1...v1.2.0) (2022-06-07) ### Features * Add wrapper module and pre-commit hook ([#3](#3)) ([c2284be](c2284be))
|
This PR is included in version 1.2.0 🎉 |
|
Super! Thanks 👌 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add wrapper module.
Motivation and Context
Terragrunt User 👋
Following the example in the terraform-aws-s3-bucket repo.
Breaking Changes
None
How Has This Been Tested?
- [ ] I have updated at least one of theexamples/*to demonstrate and validate my change(s)(Included in the wrapper README)
- [ ] I have tested and validated these changes using one or more of the providedexamples/*projects(Not sure that's required for this feat?)
pre-commit run -aon my pull request