feat!: Allow multiple scan filters per scan type in registry; Raise MSV of Terraform and AWS provider to 1.0 and 5.0 respectively #29
Conversation
There was a problem hiding this comment.
The change looks good, and we should make it as a major release since it contains a breaking change.
WDYT @bryantbiggs ?
main.tf
Outdated
| filter = rule.value.filter | ||
| filter_type = try(rule.value.filter_type, "WILDCARD") | ||
| dynamic "repository_filter" { | ||
| for_each = rule.value.filters |
There was a problem hiding this comment.
I know the plural form makes more sense, but it does throw users off - lets keep the current, singular form to avoid surprising folks:
| for_each = rule.value.filters | |
| for_each = rule.value.filter |
There was a problem hiding this comment.
Added suggested change
bryantbiggs
changed the title
…S provider to 1.0 and 5.0 respectively
|
Minimum support versions raised for Terraform and AWS provider to 1.0 and 5.0 respectively. |
## [2.0.0](v1.7.1...v2.0.0) (2024-03-15) ### ⚠ BREAKING CHANGES * Allow multiple scan filters per scan type in registry; Raise MSV of Terraform and AWS provider to 1.0 and 5.0 respectively (#29) ### Features * Allow multiple scan filters per scan type in registry; Raise MSV of Terraform and AWS provider to 1.0 and 5.0 respectively ([#29](#29)) ([cbba4fd](cbba4fd))
|
This PR is included in version 2.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Increase the functionality of AWS ECR registry scan rules by implementing the capability to accommodate multiple scan filters per scan type, thereby enhancing the flexibility and customization options available for users.
Motivation and Context
This feature became essential during my work on a project where there was a requirement to incorporate multiple filters into the scaling configuration. However, this couldn't be accomplished with the existing implementation.
Breaking Changes
Yes, 'filter' parameter under 'registry_scan_rules,' which has now been renamed to 'filters,' and its data type has been altered from a string to an array of maps. Consequently, users relying on the existing implementation must update their 'registry_scan_rules' configuration to align with these changes in order to effectively utilize the updated features.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request