Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump versions.tf for module 4.3.1 #330

Closed
1 task done
silvaalbert opened this issue Apr 21, 2023 · 6 comments · Fixed by #331
Closed
1 task done

bump versions.tf for module 4.3.1 #330

silvaalbert opened this issue Apr 21, 2023 · 6 comments · Fixed by #331

Comments

@silvaalbert
Copy link

silvaalbert commented Apr 21, 2023

Description

Please update versions.tf to reflect a requirement for Terraform version 0.15.0 or greater. The new nonsensitive function requires that version. Given that this is a breaking change, perhaps it should have been a major release.

https://developer.hashicorp.com/terraform/language/functions/nonsensitive

  • ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Versions

  • Module version [Required]: 4.3.1

  • Terraform version: < 0.15.0

@dbpyle184
Copy link

Given that this is a possible breaking change for anyone running TF prior to v15.0. Could the update to move to using the nonsentive function be reverted and released in a Major change IE 5.x.x?

@AdamTylerLynch
Copy link

@antonbabenko this change caused an impact for one of our customers.

@antonbabenko
Copy link
Member

@bryantbiggs Should we bump versions.tf to require Terraform 1.0+ in this module, also?

@bryantbiggs
Copy link
Member

yes, we can do this in #331 - just want to check a few other things first

@antonbabenko
Copy link
Member

This issue has been resolved in version 5.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants