Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputs repaired and tests added to prove counts #67

Merged
merged 3 commits into from
May 6, 2018

Conversation

brandonjbjelland
Copy link
Contributor

PR o'clock

Description

I introduced a but (to try and resolve a terraform warning turned error) by reducing the output counts by 1, thinking I had an off by 1 error. This was wrong and I cut off a resource output. I've created tests to verify output length.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/alb_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features)
  • Test results are pasted in this PR (in lieu of CI) - tests in CI but also pasted below
  • Docs have been added/updated (for bug fixes/features)
  • Any breaking changes are noted in the description above

Test summary output:

Finished in 1.11 seconds (files took 2.65 seconds to load)
52 examples, 0 failures

       Finished verifying <default-aws> (0m6.27s).
-----> Kitchen is finished. (0m7.42s)

@brandonjbjelland brandonjbjelland merged commit 274329a into master May 6, 2018
@brandonjbjelland brandonjbjelland deleted the feature/add_count_tests branch May 6, 2018 08:04
@antonbabenko
Copy link
Member

Good to see checklists. This is something I need to add to the rest of our repositories.

@brandonjbjelland
Copy link
Contributor Author

Feel free to take and improve on anything I’ve got here in your repos.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants