Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Least Outstanding Requests algorithm for load balancing requests #158

Merged
merged 4 commits into from
Aug 18, 2020

Conversation

michaelaw320
Copy link
Contributor

Description

Add optional arguments to target group: load_balancing_algorithm_type

https://www.terraform.io/docs/providers/aws/r/lb_target_group.html#load_balancing_algorithm_type

Motivation and Context

Closes #157

Breaking Changes

No breaking changes

How Has This Been Tested?

Created Load balancer with load_balancing_algorithm_type set to least_outstanding_requests, round_robin, and unset. All load balancers' target group created as it should be.

@michaelaw320 michaelaw320 changed the title Support Least Outstanding Requests algorithm for load balancing requests improvement: Support Least Outstanding Requests algorithm for load balancing requests Apr 30, 2020
@michaelaw320 michaelaw320 changed the title improvement: Support Least Outstanding Requests algorithm for load balancing requests feat: Support Least Outstanding Requests algorithm for load balancing requests Jul 15, 2020
@diasjorge
Copy link

Any chance to get this PR merged?

@antonbabenko antonbabenko merged commit 60a7b25 into terraform-aws-modules:master Aug 18, 2020
@antonbabenko
Copy link
Member

Why not 👍

v5.8.0 has been just released.

@diasjorge
Copy link

Cool. Thanks

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Least Outstanding Requests algorithm for load balancing requests
3 participants