fix: create missing validation records in cases (eg, wildcard SAN) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for distinct domain validation options
antonbabenko
approved these changes
Jun 28, 2021
| @@ -30,6 +30,7 @@ module "acm" { | |||
| "*.alerts.${local.domain_name}", | |||
| "new.sub.${local.domain_name}", | |||
| "*.${local.domain_name}", | |||
| "alerts.${local.domain_name}", | |||
There was a problem hiding this comment.
This line was enough to reproduce the error.
antonbabenko
changed the title
|
Thank you, @flora-five ! v3.1.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that a single validation record is created for both
*.domainanddomainitems fromaws_acm_certificate.this[0].domain_validation_options.Motivation and Context
Fixes #82
When wildcard SANs are used, the module may not create all the necessary validation records.
Breaking Changes
It may affect the users, if any, who have created a certificate that is not yet validated because of the missing validation records. Running
terraform applymay delete one or more existing validation records due to the recomputedvalidation_domainslist. Runningapplyone more time will be necessary to create again the validation records deleted by the previousapply.How Has This Been Tested?
Using the example from the #82
terraform consoleoutput.