feat: Add certificate transparency log option to ACM

[DrFaust92]

Description

Add certificate transparency log option to ACM
per:
https://www.terraform.io/docs/providers/aws/r/acm_certificate.html#certificate_transparency_logging_preference
https://docs.aws.amazon.com/acm/latest/userguide/acm-concepts.html#concept-transparency

[antonbabenko]

Thanks for adding this feature and reviewing this, too!

v2.6.0 has been released.

[woneill]

Should this default to false when AWS itself defaults to true?

We were surprised to see a bunch of certificates about to be recreated after upgrading to this version of the module until we noticed that certificate_transparency_logging_preference was changing from ENABLED to DISABLED.

[antonbabenko]

My bad, I was sure that @DrFaust92 and @bryantbiggs verified this, so I don't have to do it before merging. I will be able to merge a fix (if necessary) in 10-12 hours or so.

[DrFaust92]

tested it by creating a new one, was not aware the default is true. creating a new PR now.

[DrFaust92]

opened #51

[bryantbiggs]

ah yes, my apologies I did as @DrFaust92 and tested by creating anew

[antonbabenko]

@woneill Please use v2.8.0 which has been just released.

[woneill]

Thank you all for this update!

It's interesting that creating a new cert via testing might have shown different results since the AWS docs mention:

Certificate transparency logging is automatic when you request or renew a certificate unless you choose to opt out

Our certs had been created before there was even a certificate transparency log option in ACM so I assume they inherited the default settings. Perhaps there was a delay between creating a new certificate and it showing up in the transparency log?

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.