-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support to key algorithm argument #125
feat: Add support to key algorithm argument #125
Conversation
Signed-off-by: Edgar R. Sandi <[email protected]>
Signed-off-by: Edgar R. Sandi <[email protected]>
all of the versions will need to be updated to reflect the version that this attribute was added in (4.40.0) Line 7 in 8a0e0b6
|
Signed-off-by: Edgar R. Sandi <[email protected]>
Signed-off-by: Edgar R. Sandi <[email protected]>
## [4.3.0](v4.2.0...v4.3.0) (2022-12-04) ### Features * Add support to key algorithm argument ([#125](#125)) ([e35292c](e35292c))
This PR is included in version 4.3.0 🎉 |
what version AWS provider are you using? |
#125 (comment) provider "registry.terraform.io/hashicorp/aws" {
version = "4.39.0"
constraints = ">= 2.53.0, >= 3.30.0, >= 3.56.0, >= 3.73.0, >= 4.0.0, ~> 4.0, >= 4.12.0, >= 4.30.0"
hashes = [
"h1:5jIAzI33opxKT6TFoAP/UVvRKvtpDe7Dsaw20go3U7w=",
....
"zh:f68b2685ee86bcf314d74a20e97b5cbe0c63741827143f7a4ba7ec56555329dc",
]
} |
it looks like the root version was not updated like the rest of the versions - should be resolved in #126 |
@bryantbiggs Agreed. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
In the version 4.40.0 of the terraform-provider-aws was added support to set the
key algorithm
This PR adds the support to this argument in the
terraform-aws-acm
module.Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request