feat!: Added validation_option configuration and upgraded AWS provider to v4

[philicious]

Description

Adds validation_domain option as described in #105

Motivation and Context

The ACM-request option --domain-validation-options ValidationDomain=bar.com,DomainName="foo.bar.com" for modifying the domain used for sending the validation email to, couldnt be used yet as the TF-provider didnt support it. Finally, after only 4yrs being open, the PR got merged and its available in provider 4.12.0

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[antonbabenko]

@bryantbiggs Should this also be a major release? Sometimes I have mixed feelings and am unsure whether a major release is a right decision when the AWS provider goes up from v2 to v4.

[bryantbiggs]

@antonbabenko ya - I think any provider major version update is automatically a module version update. It forces users to upgrade their provider version. We will potentially have a lot of major version upgrades in modules for this but I guess thats how it goes

[philicious]

@antonbabenko is there anything left for me to finish this up ?

[philicious]

@antonbabenko could you do a release with this please ?
Would be really appreciated, thank you 🙏!

[bryantbiggs]

@philicious can you also bump the required minimum Terraform version to 1.0 since we're taking this as a breaking change

[philicious]

@bryantbiggs will do tomorrow 👍🏼

[philicious]

@bryantbiggs we somehow managed to commit the same change almost at the same time :D

[bryantbiggs]

@philicious should we support this through the separate resource instead of the nested attribute in the certificate resource https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acm_certificate_validation ?

I don't see anything currently that prefers one way versus the other, but in other modules I know its been preferable to use the standalone resource rather than the nested attribute.

[Edit] Or are these two different things that I am confusing 😅

[philicious]

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acm_certificate_validation

@bryantbiggs afaict the acm_certificate_validation is already present in the module

terraform-aws-acm/main.tf

Lines 53 to 59 in 3e88a71

	resource "aws_acm_certificate_validation" "this" {
	count = local.create_certificate && var.validation_method != "NONE" && var.validate_certificate && var.wait_for_validation ? 1 : 0
	certificate_arn = aws_acm_certificate.this[0].arn
	validation_record_fqdns = flatten([aws_route53_record.validation.*.fqdn, var.validation_record_fqdns])
	}

afaiu it has a different purpose: retrieving the status of validation, not configuring validation method. So imho it should also work for domains that have an overridden domain name

[antonbabenko]

LGTM, if @philicious can confirm that you ran code in the examples/complete-email-validation-with-validation-domain and that it works as expected.

[antonbabenko]

This PR is included in version 4.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.