Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Image class an abstact base class #804

Closed
nishakm opened this issue Sep 10, 2020 · 1 comment
Closed

Make the Image class an abstact base class #804

nishakm opened this issue Sep 10, 2020 · 1 comment
Labels
refactor Requires significant code refactoring super Super issue - other issues are linked to this one technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred
Milestone
Release 3.0.0

Comments

@nishakm
Copy link
Contributor

nishakm commented Sep 10, 2020

Description
Image is currently a generic container image class. Convert this into an abstract base class in order to restrict the kind of properties and methods that are allowed.

To Do

  1. Convert the Image class in tern/classes/image.py to derive from the ABS class
  2. Update the DockerImage class to compensate for the update if needed.

Background
This should unblock #678

Super Issues
#801
@nishakm nishakm added super Super issue - other issues are linked to this one technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred labels Sep 10, 2020
@nishakm nishakm added this to the 3.0.0 milestone Sep 10, 2020
@nishakm nishakm mentioned this issue Sep 10, 2020
Closed
@nishakm nishakm added the refactor Requires significant code refactoring label Sep 11, 2020
@nishakm
Copy link
Contributor Author

nishakm commented Dec 21, 2021

This is done.

@nishakm nishakm closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Requires significant code refactoring super Super issue - other issues are linked to this one technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred
Projects
None yet
Milestone
Release 3.0.0
Development

No branches or pull requests
1 participant
@nishakm