Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Close keyboard when clicking in the background #2314

Closed
cdhiraj40 opened this issue Oct 3, 2021 · 6 comments
Closed

[Feature]: Close keyboard when clicking in the background #2314

cdhiraj40 opened this issue Oct 3, 2021 · 6 comments

Comments

@cdhiraj40
Copy link

Feature description

Activities do not support closing the keyboard when clicking in the background, having this feature will def make a better user experience

Additional information

https://github.com/cdhiraj40/enviroCar-app
and just got approval to add this in https://github.com/cdhiraj40/AntennaPod

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Oct 3, 2021

What "background" are you referring to?

Tapping the terminal text area opens the keyboard if it's closed, just like normal edit text fields in android. No reason to close it for that when tapping and termux app doesn't even know if keyboard is open or closed anyways (unless disabled). You can use KEYBOARD extra key to toggle the keyboard.

https://wiki.termux.com/wiki/Touch_Keyboard

@cdhiraj40
Copy link
Author

cdhiraj40 commented Oct 3, 2021

What "background" are you referring to?

Tapping the terminal text area opens the keyboard if it's closed, just like normal edit text fields in android. No reason to close it for that when tapping and the termux app doesn't even know if the keyboard is open or closed anyways (unless disabled). You can use the KEYBOARD extra key to toggle the keyboard.

https://wiki.termux.com/wiki/Touch_Keyboard

I was referring to the terminal text area only
I just thought it would be good the way it opens the keyboard when clicked in the terminal it closes too. But I guess there is no need to do that. Anyways if you approve then only I work. thanks :)

@agnostic-apollo
Copy link
Member

The terminal text area is an edit text field itself, it is not the background. When you type in a edit text field, like url in a browser or in chats, tapping it again doesn't close keyboard, it stays open. That's the current termux behaviour and must not be changed by default. Even if more users request toggling, a termux.properties property would need to be added for it and then changes tested rigourously since keyboard logic is quite complex in termux, read the keyboard logic in the file linked above, it's near the bottom. Also check #2114 (comment).

@cdhiraj40
Copy link
Author

cdhiraj40 commented Oct 4, 2021

The terminal text area is an edit text field itself, it is not the background. When you type in a edit text field, like url in a browser or in chats, tapping it again doesn't close keyboard, it stays open. That's the current termux behaviour and must not be changed by default. Even if more users request toggling, a termux.properties property would need to be added for it and then changes tested rigourously since keyboard logic is quite complex in termux, read the keyboard logic in the file linked above, it's near the bottom. Also check #2114 (comment).

okay, I read it and understood the behavior. thanks for the help.(you may close this now) according to you are there any issues where I can work on it? would love to contribute :)

@SDRausty

This comment was marked as spam.

@agnostic-apollo
Copy link
Member

are there any issues where I can work on it?

There are a lot of issues open for termux-app and the other termux plugin apps, you can look into those and see what you can actually implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants