Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets doesn't handle version correctly #639

Closed
kstaken opened this issue Dec 18, 2017 · 5 comments
Closed

Assets doesn't handle version correctly #639

kstaken opened this issue Dec 18, 2017 · 5 comments

Comments

@kstaken
Copy link
Member

kstaken commented Dec 18, 2017

It doesn't consider 0.0.11 or 0.0.12 to be greater than 0.0.10

@godber
Copy link
Member

godber commented Dec 18, 2017

If you're not using something like semver you should probably consider it.

@kstaken
Copy link
Member Author

kstaken commented Jan 5, 2018

It's possible this issue may not be the version but I'm definitely seeing cases where a new version of an asset is published but a stored job continues to use an older version. It appears that maybe the validation on creation of the new execution isn't working correctly.

Just has this situation with an asset versioned 0.0.2 and then 0.0.3 was published. The job was stopped and started but continued with the older asset. The stored job has the old asset_id as an explicit ID.

Something that occurs to me is that this job was updated via PUT. Doing that again I see the stored job gets the correct asset_id for 0.0.3 but it's storing the asset_id in the job instead of leaving it as the name. With that the execution will always use the old version because the asset_id will never change. I think this ties in with @godber's comments in #634. The job should be stored as submitted, not as validated.

@kstaken
Copy link
Member Author

kstaken commented Jan 10, 2018

This should be resolved with the fixes for #634 in v0.28.0.

@kstaken kstaken closed this as completed Jan 10, 2018
@kstaken kstaken reopened this Jan 11, 2018
@kstaken
Copy link
Member Author

kstaken commented Jan 11, 2018

This issue isn't fixed. Updating existing jobs still converts asset names into IDs.

@kstaken
Copy link
Member Author

kstaken commented Jan 11, 2018

Closing to defer to #634 which is more specific.

@kstaken kstaken closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants