Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set prom_metrics_display_url automatically #3852

Open
briend opened this issue Dec 5, 2024 · 0 comments
Open

Set prom_metrics_display_url automatically #3852

briend opened this issue Dec 5, 2024 · 0 comments
Assignees
Labels
helmchart helm chart related

Comments

@briend
Copy link
Contributor

briend commented Dec 5, 2024

Previously in the Helm Chart, we were setting TERASLICE_DISPLAY_URL env variable manually to whatever we configured the ingress for. It would be convenient if prom_metrics_display_url for the new internal metrics server was configured automatically for us, and include a trailing / to preserve the behavior of the old exporter.

Basically some logic in the templating that would do something like this:

  • If ingress is enabled, pick the first host in the hosts array and set prom_metrics_display_url to that, but also set http(s) appropriately, and add a trailing / if necessary. ex https://teraslice.local/
  • Otherwise, if ingress is not enabled, leave prom_metrics_display_url unset.
  • if prom_metrics_display_url is set by user, use that as-is without any modification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helmchart helm chart related
Projects
None yet
Development

No branches or pull requests

3 participants