Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should validate provided master node #3

Open
godber opened this issue Jan 27, 2017 · 3 comments
Open

Should validate provided master node #3

godber opened this issue Jan 27, 2017 · 3 comments

Comments

@godber
Copy link
Member

godber commented Jan 27, 2017

The cluster master node is provided as an argument to the script. The script should at the very least check to see if a ES cluster is on the provided host and port. It would be best to verify that all of the provided nodes and master are members of the same cluster too.

@godber
Copy link
Member Author

godber commented Feb 2, 2017

This ticket was so great I wrote it twice! dupe #5

@erik-stephens
Copy link
Contributor

Instead of having using provide as an arg, how about looking up the currently elected master automatically? Removes a manual step and some potential for human error.

@godber
Copy link
Member Author

godber commented Jun 29, 2017

I think I get what you're saying. You're saying that we shouldn't bother providing a master at all, it should be queried from the hosts in the list, right? That's a good idea. Given that, my concern still exists ... I am afraid of a case where people create a list that has nodes from two different clusters. We should ensure that all the nodes in the list are in the same cluster. That's the main point of this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants