Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in dbGetInfo method #8

Closed
mdsumner opened this issue Jan 4, 2016 · 4 comments
Closed

bug in dbGetInfo method #8

mdsumner opened this issue Jan 4, 2016 · 4 comments

Comments

@mdsumner
Copy link

mdsumner commented Jan 4, 2016

I believe this method should be more something like this:

setMethod("dbGetInfo", "ODBCConnection",
          function (dbObj, ...) {
    info <- RODBC::odbcGetInfo(dbObj@odbc)
    list(host = info["DBMS_Name"], serverVersion = info["DBMS_Ver"], user = "", host = "", port = "",       dbname = info["Data_Source_Name"])
 }
)

Currently it's trying to do dbObj(dbObj, ...) which doesn't make sense. I haven't worked through other aspects related to the return object, but this is working for me for dplyr now. Thanks

@teramonagi
Copy link
Owner

OK, i will fix it quickly based on your code.

but this is working for me for dplyr now. Thanks

Oh I want to know this!
Could you show me an example?

@mdsumner
Copy link
Author

mdsumner commented Jan 4, 2016

Sorry, that was premature! It's kind of working, I had some issues and not sure if they are problems with RODBCDBI or something I'm doing. I got all the way through the "Adding a SQL back-end" vignette until the tbl(x, "tablename") - still have to figure out some more. I send what I have soon

@teramonagi
Copy link
Owner

What you are trying to do is one of the things which I really wana do... Keep up the good work!

@teramonagi
Copy link
Owner

Fixed! You can install the fixed package by the following command.

devtools::install_github("teramonagi/RODBCDBI")

Thanks alot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants