Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-ecs-discovery not able to discover targets on EC2 with disabled DNS hostnames #63

Open
zsaurabhsabharwal opened this issue Apr 2, 2021 · 1 comment
Open

prometheus-ecs-discovery not able to discover targets on EC2 with disabled DNS hostnames #63

zsaurabhsabharwal opened this issue Apr 2, 2021 · 1 comment
Labels
help wanted

Comments

@zsaurabhsabharwal
Copy link

On EC2 machines with DNS hostnames disabled, this check fails and as a result returns without processing that particular task.

This can be fixed by removing this check completely and instead extracting the IP address directly from EC2 instance description.

 ip = *t.EC2Instance.PrivateIpAddress
@chicofranchico
Copy link
Contributor

What will happen if the instance has more than one private IP address? (also, could you update the code reference? I think it got messed up with latest merges)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chicofranchico @zsaurabhsabharwal