Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation tests #446

Open
51-code opened this issue Dec 4, 2024 · 0 comments
Open

Improve translation tests #446

51-code opened this issue Dec 4, 2024 · 0 comments
Labels
feature Existing feature

Comments

@51-code
Copy link
Contributor

51-code commented Dec 4, 2024

Description

Translation tests currently use protected or public variables in Step classes to check if the translation from DPL was correct. A better way could be to override equals and hashCode methods, then write tests that compare a carefully crafted step to the translation result.

Not as simple of a task as it sounds though, as equality tests will force the objects to be immutable. Right now, AbstractStep uses a mutable field aggregationsUsedBefore, so it has to be refactored. Some regular steps are probably mutable currently as well.

Related to #202 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Existing feature
Projects
None yet
Development

No branches or pull requests

1 participant