Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcards in keyword slows down the search #246

Closed
ronja-ui opened this issue Mar 28, 2024 · 4 comments
Closed

Wildcards in keyword slows down the search #246

ronja-ui opened this issue Mar 28, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ronja-ui
Copy link
Contributor

Describe the bug
Wildcards in keyword slows down the search tremendously.

Expected behavior
The search time should be endurable even with wildcards.

How to reproduce
Following query takes forever:

%dpl
index=[dataset] earliest="10/10/2023:13:00:00" latest="10/10/2023:13:10:00" "*[keyword]*"

Versus this query is quite quick:

%dpl
index=[dataset] earliest="10/10/2023:13:00:00" latest="10/10/2023:13:10:00" "[keyword]"

Screenshots

Software version
pth_07 5.17.0

Desktop (please complete the following information if relevant):

  • OS:
  • Browser:
  • Version:

Additional context

@ronja-ui ronja-ui added the bug Something isn't working label Mar 28, 2024
@eemhu
Copy link
Contributor

eemhu commented Apr 3, 2024

If wildcards are used in search, bloom.withoutFilter is set to true on the datasource.
Could this be the culprit?

@eemhu
Copy link
Contributor

eemhu commented Apr 4, 2024

Also in fact currently these * wildcards are considered normal characters and it would search for a literal *keyword*, which most likely won't result in any search results

@elliVM
Copy link
Contributor

elliVM commented Apr 8, 2024

@eemhu If the goal is to disable bloom completely if a wildcard is used, instead of bloom.withoutFilters use the bloom.enabled option set to false. withoutFilter option limits archive files to those that don't have a generated bloom filter so you could miss some wildcard matches. I assume in a wildcard search the presence of a bloom filter should not have any effect in search results.

@eemhu
Copy link
Contributor

eemhu commented Apr 8, 2024

changed config to bloom.enabled in pull request

@eemhu eemhu closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants