Adds prometheus metrics endpoint #24
Conversation
|
Will include the DropWizard stats on the same PR as further commit as they are linked together |
|
Implemented some of the metrics, and they require plenty of review especially with the errors/reconnects/connections part |
| public class RelpOutput { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(RelpOutput.class); | ||
| private final RelpConnection relpConnection; | ||
| private final AppConfigRelp relpConfig; | ||
| private final int id; | ||
|
|
||
| Counter totalReconnects; |
|
|
||
| private void loadMetrics() { | ||
| // All registered through PrometheusMetrics | ||
| MetricRegistry metricRegistry = SharedMetricRegistries.getOrCreate("default"); |
There was a problem hiding this comment.
pass rather as an object in constructor than singleton getter
StrongestNumber9
force-pushed
the
prometheus
branch
from
dd1974a to
e675463
Compare
StrongestNumber9
force-pushed
the
prometheus
branch
from
e675463 to
c02a038
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| FROM rockylinux:8 | |||
| COPY rpm/target/rpm/com.teragrep-k8s_01/RPMS/noarch/com.teragrep-k8s_01-*.rpm /rpm/ | |||
| RUN dnf -y install jq java-1.8.0-headless /rpm/*.rpm && yum clean all | |||
| RUN dnf -y install jq /rpm/*.rpm && yum clean all | |||
There was a problem hiding this comment.
DL3040: dnf clean all missing after dnf command.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| @@ -1,6 +1,6 @@ | |||
| FROM rockylinux:8 | |||
| COPY rpm/target/rpm/com.teragrep-k8s_01/RPMS/noarch/com.teragrep-k8s_01-*.rpm /rpm/ | |||
| RUN dnf -y install jq java-1.8.0-headless /rpm/*.rpm && yum clean all | |||
| RUN dnf -y install jq /rpm/*.rpm && yum clean all | |||
There was a problem hiding this comment.
DL3041: Specify version with dnf install -y <package>-<version>.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
Requested fixes done, self approving for now |
No description provided.