Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Instant objects to measure time across the code to stay consistent #46

Open
Laukkala opened this issue Dec 3, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@Laukkala
Copy link

Laukkala commented Dec 3, 2024

Description
There are multiple different ways to measure time in the project, and it would be good to keep measurement of time consistent.
At least in SyslogRecordEventID.java, there is usage of System.currentTimeMillis, while elsewhere Instant is used.

Use case or motivation behind the feature request
Instant seems to be the prevailing method of measuring time, so it should be used across different classes to stay consistent. There might be slight differences in the way Instant and System classes provide timestamps, and it might lead to confusing errors in the future.

@Laukkala Laukkala added the enhancement New feature or request label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant