-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause icon in paragraph-control is not clickable but disabled #204
Comments
the code related to this issue is highly spaghettified. Currently, there are three different methods in paragraph controller:
What else does isNoteRunning do? Quite a lot, actually:
Additionally, the "cancelParagraph(paragraph)" function, which is called by the button click, is only doing one thing: it sends the websocket call "CANCEL_PARAGRAPH" with paragraphID provided. It does not have any additional logic in it and has no feedback. Therefore, if call is sent, but ignored/returns error (and we know how current error handling is performing) - user will see nothing and will think that button is unclickable. |
Current decision: User stories: |
In paragraph-control when you click run paragraph button, it shows a pause button that looks clickable but actually isn't.
<i class="fas fa-pause" role="button" title="Cancel (Ctrl+{{ (isMac ? 'Option' : 'Alt') }}+C)" ng-click="cancelParagraph(paragraph)" ng-class="{'item-disable' : isNoteRunning}"> </i>
When .item-disable class name (which is not the best name) is attached to the icon, it makes the pause icon light blue. When there's no .item-disable class name, the pause icon is red.
Sometimes the pause icon is disabled, sometimes it's not. It's confusing for the user.
Investigate how the feature is implemented and figure out a better UX for it.
The text was updated successfully, but these errors were encountered: