[wasm] Add Multinomial kernel #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @Linchenn)
Linchenn
approved these changes
Mar 13, 2023
mattsoulanille
approved these changes
Mar 13, 2023
Comment on lines
+52
to
+56
| const probabilities = normalized ? logits : softmax({ | ||
| inputs: {logits}, | ||
| backend, | ||
| attrs: {dim: logits.shape.length - 1}, | ||
| }); |
There was a problem hiding this comment.
Nit: You might not need to normalize this. It looks like std::discrete_distribution normalizes it for you. No harm in normalizing it here too, though.
There was a problem hiding this comment.
std::discrete_distribution normalizes it with w'_i = w_i / sum(...w), not softmax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fixed a bug in
tf.fill.Surprisingly tfjs-node does not pass the new tests on seed. I will file an issue after merging this PR.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is