Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add atan kernel #7252

Merged
merged 3 commits into from
Jan 6, 2023
Merged

[wasm] Add atan kernel #7252

merged 3 commits into from
Jan 6, 2023

Conversation

chunnienc
Copy link
Collaborator

@chunnienc chunnienc commented Jan 6, 2023

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for ramping up so quickly. a minor nitpick on the PR.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @chunnienc)


tfjs-backend-wasm/src/setup_test.ts line 405 at r1 (raw file):

  {include: 'reciprocal'},
  {include: 'isNaN'},
  {include: 'atan '},

please remove the trailing space, I think the description of atan tests only contains 'atan'.

@chunnienc
Copy link
Collaborator Author

chunnienc commented Jan 6, 2023

Thanks you for ramping up so quickly. a minor nitpick on the PR.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @chunnienc)

tfjs-backend-wasm/src/setup_test.ts line 405 at r1 (raw file):

  {include: 'reciprocal'},
  {include: 'isNaN'},
  {include: 'atan '},

please remove the trailing space, I think the description of atan tests only contains 'atan'.

The test filter applies on the resolved/expanded test name e.g. this test's name for matching would be "atan basic", so it matches the filter with the trailing space.

Besides:

  1. The current filter with trailing space could fail with my intended incorrect implementation, which means the atan tests are properly included.
  2. The filter without trailing space failed since it includes other tests for 'atan2' and 'atanh'.

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @chunnienc)


tfjs-backend-wasm/src/setup_test.ts line 405 at r1 (raw file):

Previously, chunnienc wrote…

The test filter applies on the resolved/expanded test name e.g. this test's name for matching would be "atan basic", so it matches the filter with the trailing space.

Besides:

  1. The current filter with trailing space could fail with my intended incorrect implementation, which means the atan tests are properly included.
  2. The filter without trailing space failed since it includes other tests for 'atan2' and 'atanh'.

awesome, thank you for the clarification, trailing space would be a good way to avoid other ops.

@pyu10055 pyu10055 merged commit 7efa66c into tensorflow:master Jan 6, 2023
@chunnienc chunnienc deleted the wasm-atan branch January 6, 2023 21:12
Linchenn pushed a commit to Linchenn/tfjs that referenced this pull request Jan 9, 2023
FEATURE
* [wasm] Add atan kernel

* fmt

Co-authored-by: Matthew Soulanille <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants