-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add atan kernel #7252
[wasm] Add atan kernel #7252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for ramping up so quickly. a minor nitpick on the PR.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @chunnienc)
tfjs-backend-wasm/src/setup_test.ts
line 405 at r1 (raw file):
{include: 'reciprocal'}, {include: 'isNaN'}, {include: 'atan '},
please remove the trailing space, I think the description of atan tests only contains 'atan'.
The test filter applies on the resolved/expanded test name e.g. this test's name for matching would be Besides:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 2 of 1 approvals obtained (waiting on @chunnienc)
tfjs-backend-wasm/src/setup_test.ts
line 405 at r1 (raw file):
Previously, chunnienc wrote…
The test filter applies on the resolved/expanded test name e.g. this test's name for matching would be
"atan basic"
, so it matches the filter with the trailing space.Besides:
- The current filter with trailing space could fail with my intended incorrect implementation, which means the atan tests are properly included.
- The filter without trailing space failed since it includes other tests for 'atan2' and 'atanh'.
awesome, thank you for the clarification, trailing space would be a good way to avoid other ops.
FEATURE * [wasm] Add atan kernel * fmt Co-authored-by: Matthew Soulanille <[email protected]>
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is