Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7104 - tf.initializers.<random | glorot | he | leCunn>Uniform() ignores seed argument #7108

Conversation

adrian-branescu
Copy link
Contributor

@adrian-branescu adrian-branescu commented Nov 25, 2022

Fix #7104 - tf.initializers.<random | glorot | he | leCunn>Uniform() ignores seed argument & add tests that replicated the issue, fix wrong serialization name registered for LeCunUniform initializer class

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

adrian-branescu and others added 2 commits November 25, 2022 15:21
…Uniform() ignores seed argument & add tests that replicated the issue, fix wrong serialization name registered for LeCunUniform initializer class
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@mattsoulanille mattsoulanille merged commit aa14065 into tensorflow:master Nov 29, 2022
Linchenn pushed a commit to Linchenn/tfjs that referenced this pull request Jan 9, 2023
…Uniform() ignores seed argument & add tests that replicated the issue, fix wrong serialization name registered for LeCunUniform initializer class (tensorflow#7108)

Fix tensorflow#7104 - tf.initializers.<random | glorot | he | leCunn>Uniform() ignores seed argument & add tests that replicated the issue, fix wrong serialization name registered for LeCunUniform initializer class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tf.initializers.<random | glorot | he | leCunn>Uniform() ignores seed argument
3 participants