Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flag ENGINE_COMPILE_ONLY from Core to WebGL backend #7019

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Nov 8, 2022

Since this flag currently is only meaningful for WebGL backend, so moves it from Core to WebGL backend.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@Linchenn Linchenn requested review from lina128 and pyu10055 November 8, 2022 00:35
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@Linchenn Linchenn merged commit 81fa34e into tensorflow:master Nov 8, 2022
@Linchenn Linchenn deleted the mvFlg branch November 8, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants