[webgpu] Tweak WGSL entry point emission so '{' isn't visually swallowed #6764
Conversation
| @builtin(num_workgroups) NumWorkgroups : vec3<u32>) { | ||
| localId = LocalId; | ||
| globalId = GlobalId; | ||
| numWorkgroups = NumWorkgroups; |
There was a problem hiding this comment.
Can you check if numWorkgroups = NumWorkgroups; is still needed for this case? I expect if we use non-linear work group size, we can totally remove the dependency on num_workgroups and getGlobalIndex(). I am ok to do it in a follow-up PR. Thanks.
There was a problem hiding this comment.
I don't feel it's safe to assume getGlobalIndex() is unused elsewhere. E.g. we currently have this dependency chain in depth-wise conv2d: main() -> getOutputCoords() -> getGlobalIndex().
There was a problem hiding this comment.
getGlobalIndex() is only called when x.length === outRank in getOutputCoords, which means a flat dispatch layout. Let's keep it for now. Maybe it's not necessary to worry about the very small overhead of NumWorkgroups .
There was a problem hiding this comment.
I do find the x.length === outRank branch is taken while running depthwise_conv2d_test, is this expected?
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is