[browserstack benchmark tool] Enable customizing local builds #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
32
to
41
| "build-all-deps": "yarn build-link-package && yarn build-tfjs", | ||
| "build-tfjs": "cd ../../../tfjs && yarn && yarn build-npm", | ||
| "build-link-package": "cd ../../../link-package && yarn build", | ||
| "build-backend-cpu": "cd ../../../tfjs-backend-cpu && yarn && yarn build-npm", | ||
| "build-backend-wasm": "cd ../../../tfjs-backend-wasm && yarn && yarn build && yarn build-npm", | ||
| "build-backend-webgl": "cd ../../../tfjs-backend-webgl && yarn && yarn build && yarn build-npm", | ||
| "build-converter": "cd ../../../tfjs-converter && yarn && yarn build && yarn build-npm", | ||
| "build-core": "cd ../../../tfjs-core && yarn && yarn build && yarn build-npm", | ||
| "build-data": "cd ../../../tfjs-data && yarn && yarn build", | ||
| "build-layers": "cd ../../../tfjs-layers && yarn && yarn build && yarn build-npm", |
There was a problem hiding this comment.
You can remove the build-[some-package] scripts that you replaced with build-link-package. This includes all the Bazel packages, although you'll have to leave the non-bazel packages' scripts here.
There was a problem hiding this comment.
Thank you Matt!
I just updated the scripts here, as:
"build-all-link-packages": "cd ../../../link-package && yarn build",
"build-individual-link-package": "cd ../../../link-package && yarn build-deps-for",
mattsoulanille
approved these changes
Aug 2, 2022
lina128
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Thank you so much Lin and Matt!
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @mattsoulanille)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
--webDepswith--localBuild=...arguments for both browserstack benchmark's Website tool and Command Line tool. As a result, users could customize local builds, instead of using 'all local build' or 'all web deps'.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is