Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra semicolon in tensorflow/lite/micro/micro_profiler.h:90 #61898

Closed
matthewbstokes-zz opened this issue Sep 18, 2023 · 5 comments
Closed

Extra semicolon in tensorflow/lite/micro/micro_profiler.h:90 #61898

matthewbstokes-zz opened this issue Sep 18, 2023 · 5 comments
Assignees
Labels
comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers type:docs-bug Document issues

Comments

@matthewbstokes-zz
Copy link

Remove extra semicolon in tensorflow/lite/micro/micro_profiler.h on line 90

Before:

TF_LITE_REMOVE_VIRTUAL_DELETE;

After:

TF_LITE_REMOVE_VIRTUAL_DELETE
@tilakrayal tilakrayal added comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers type:docs-bug Document issues awaiting PR merge awaiting PR merge labels Sep 19, 2023
@tilakrayal
Copy link
Contributor

@matthewbstokes-zz,
Thank you for pointing out the error. As this issue is related to tf-lite/micro, I raised the PR for the above mentioned error. Kindly find the PR details here and will update once the related PR gets merged. Thank you!

@tilakrayal
Copy link
Contributor

@matthewbstokes-zz,
The related PR got merged and the changes have been done in the mentioned file. Kindly find the reference below
tensorflow/tflite-micro#2235

https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/micro_profiler.h#L90

  TicksPerTag total_ticks_per_tag[kMaxEvents] = {};

  int FindExistingOrNextPosition(const char* tag_name);

  TF_LITE_REMOVE_VIRTUAL_DELETE
};

#if defined(TF_LITE_STRIP_ERROR_STRINGS)

Thank you!

@tilakrayal tilakrayal added stat:awaiting response Status - Awaiting response from author and removed awaiting PR merge awaiting PR merge labels Sep 22, 2023
@github-actions
Copy link

This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Sep 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.

@github-actions github-actions bot closed this as completed Oct 7, 2023
@google-ml-butler google-ml-butler bot removed stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author labels Oct 7, 2023
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers type:docs-bug Document issues
Projects
None yet
Development

No branches or pull requests

2 participants