From e2f8558f6eaa8a9d1e9920964e287f56f97e6a53 Mon Sep 17 00:00:00 2001 From: Riley Jones Date: Wed, 16 Aug 2023 16:45:52 +0000 Subject: [PATCH 1/5] start using expect_angular_legacy_material_checkbox --- tensorboard/webapp/angular/BUILD | 2 +- tensorboard/webapp/metrics/views/right_pane/BUILD | 4 ++-- .../metrics/views/right_pane/scalar_column_editor/BUILD | 2 +- tensorboard/webapp/runs/views/runs_table/BUILD | 4 ++-- tensorboard/webapp/settings/_views/BUILD | 4 ++-- tensorboard/webapp/widgets/data_table/BUILD | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tensorboard/webapp/angular/BUILD b/tensorboard/webapp/angular/BUILD index b7fb89ec9c..66b8d71285 100644 --- a/tensorboard/webapp/angular/BUILD +++ b/tensorboard/webapp/angular/BUILD @@ -80,7 +80,7 @@ tf_ts_library( # This is a dummy rule used as a @angular/material/checkbox dependency. tf_ts_library( - name = "expect_angular_material_checkbox", + name = "expect_angular_legacy_material_checkbox", srcs = [], deps = [ "@npm//@angular/material", diff --git a/tensorboard/webapp/metrics/views/right_pane/BUILD b/tensorboard/webapp/metrics/views/right_pane/BUILD index 81b68a3598..27f3c53dac 100644 --- a/tensorboard/webapp/metrics/views/right_pane/BUILD +++ b/tensorboard/webapp/metrics/views/right_pane/BUILD @@ -29,7 +29,7 @@ tf_ng_module( "//tensorboard/webapp:selectors", "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_material_button_toggle", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_icon", "//tensorboard/webapp/angular:expect_angular_material_select", "//tensorboard/webapp/angular:expect_angular_material_slider", @@ -59,7 +59,7 @@ tf_ts_library( "//tensorboard/webapp:selectors", "//tensorboard/webapp/angular:expect_angular_core_testing", "//tensorboard/webapp/angular:expect_angular_material_button_toggle", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_select", "//tensorboard/webapp/angular:expect_angular_material_slider", "//tensorboard/webapp/angular:expect_angular_platform_browser_animations", diff --git a/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD b/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD index e24c73fd1b..4685d21c00 100644 --- a/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD +++ b/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD @@ -26,7 +26,7 @@ tf_ng_module( deps = [ "//tensorboard/webapp:app_state", "//tensorboard/webapp:selectors", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_tabs", "//tensorboard/webapp/metrics:types", "//tensorboard/webapp/metrics/actions", diff --git a/tensorboard/webapp/runs/views/runs_table/BUILD b/tensorboard/webapp/runs/views/runs_table/BUILD index 4d936d8af1..3e7a3115c0 100644 --- a/tensorboard/webapp/runs/views/runs_table/BUILD +++ b/tensorboard/webapp/runs/views/runs_table/BUILD @@ -82,7 +82,7 @@ tf_ng_module( "//tensorboard/webapp/alert", "//tensorboard/webapp/alert/actions", "//tensorboard/webapp/angular:expect_angular_material_button", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_form_field", "//tensorboard/webapp/angular:expect_angular_material_icon", @@ -140,7 +140,7 @@ tf_ts_library( "//tensorboard/webapp/alert/actions", "//tensorboard/webapp/angular:expect_angular_cdk_overlay", "//tensorboard/webapp/angular:expect_angular_core_testing", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_input", "//tensorboard/webapp/angular:expect_angular_material_menu", diff --git a/tensorboard/webapp/settings/_views/BUILD b/tensorboard/webapp/settings/_views/BUILD index 3e6f5f5324..1ed8307b06 100644 --- a/tensorboard/webapp/settings/_views/BUILD +++ b/tensorboard/webapp/settings/_views/BUILD @@ -19,7 +19,7 @@ tf_ng_module( deps = [ "//tensorboard/webapp:tb_polymer_interop_types", "//tensorboard/webapp/angular:expect_angular_material_button", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_icon", "//tensorboard/webapp/angular:expect_angular_material_input", @@ -45,7 +45,7 @@ tf_ts_library( "//tensorboard/webapp/angular:expect_angular_cdk_overlay", "//tensorboard/webapp/angular:expect_angular_core_testing", "//tensorboard/webapp/angular:expect_angular_material_button", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_icon", "//tensorboard/webapp/angular:expect_angular_material_input", diff --git a/tensorboard/webapp/widgets/data_table/BUILD b/tensorboard/webapp/widgets/data_table/BUILD index eed2d32dfb..59f263a820 100644 --- a/tensorboard/webapp/widgets/data_table/BUILD +++ b/tensorboard/webapp/widgets/data_table/BUILD @@ -147,7 +147,7 @@ tf_ng_module( ], deps = [ ":types", - "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/widgets/filter_input", "//tensorboard/webapp/widgets/range_input", "//tensorboard/webapp/widgets/range_input:types", From 292e5a9beb5c16c414082522048756fd940e0719 Mon Sep 17 00:00:00 2001 From: Riley Jones Date: Wed, 16 Aug 2023 16:51:49 +0000 Subject: [PATCH 2/5] replace all does not apply formating --- tensorboard/webapp/metrics/views/right_pane/BUILD | 4 ++-- tensorboard/webapp/runs/views/runs_table/BUILD | 2 +- tensorboard/webapp/settings/_views/BUILD | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tensorboard/webapp/metrics/views/right_pane/BUILD b/tensorboard/webapp/metrics/views/right_pane/BUILD index 27f3c53dac..e1922c910e 100644 --- a/tensorboard/webapp/metrics/views/right_pane/BUILD +++ b/tensorboard/webapp/metrics/views/right_pane/BUILD @@ -27,9 +27,9 @@ tf_ng_module( deps = [ "//tensorboard/webapp:app_state", "//tensorboard/webapp:selectors", + "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_material_button_toggle", - "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", "//tensorboard/webapp/angular:expect_angular_material_icon", "//tensorboard/webapp/angular:expect_angular_material_select", "//tensorboard/webapp/angular:expect_angular_material_slider", @@ -58,8 +58,8 @@ tf_ts_library( "//tensorboard/webapp:app_state", "//tensorboard/webapp:selectors", "//tensorboard/webapp/angular:expect_angular_core_testing", - "//tensorboard/webapp/angular:expect_angular_material_button_toggle", "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_material_button_toggle", "//tensorboard/webapp/angular:expect_angular_material_select", "//tensorboard/webapp/angular:expect_angular_material_slider", "//tensorboard/webapp/angular:expect_angular_platform_browser_animations", diff --git a/tensorboard/webapp/runs/views/runs_table/BUILD b/tensorboard/webapp/runs/views/runs_table/BUILD index 3e7a3115c0..8ab1b9c3d9 100644 --- a/tensorboard/webapp/runs/views/runs_table/BUILD +++ b/tensorboard/webapp/runs/views/runs_table/BUILD @@ -81,8 +81,8 @@ tf_ng_module( "//tensorboard/webapp:selectors", "//tensorboard/webapp/alert", "//tensorboard/webapp/alert/actions", - "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_form_field", "//tensorboard/webapp/angular:expect_angular_material_icon", diff --git a/tensorboard/webapp/settings/_views/BUILD b/tensorboard/webapp/settings/_views/BUILD index 1ed8307b06..14a9e54d4f 100644 --- a/tensorboard/webapp/settings/_views/BUILD +++ b/tensorboard/webapp/settings/_views/BUILD @@ -18,8 +18,8 @@ tf_ng_module( ], deps = [ "//tensorboard/webapp:tb_polymer_interop_types", - "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_icon", "//tensorboard/webapp/angular:expect_angular_material_input", @@ -44,8 +44,8 @@ tf_ts_library( ":_views", "//tensorboard/webapp/angular:expect_angular_cdk_overlay", "//tensorboard/webapp/angular:expect_angular_core_testing", - "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_material_button", "//tensorboard/webapp/angular:expect_angular_material_dialog", "//tensorboard/webapp/angular:expect_angular_material_icon", "//tensorboard/webapp/angular:expect_angular_material_input", From 92f7ab8d5c19184a1283543f6b48cc21baae3726 Mon Sep 17 00:00:00 2001 From: Riley Jones Date: Wed, 16 Aug 2023 16:57:41 +0000 Subject: [PATCH 3/5] readd the expect_angular_material_checkbox build rule --- tensorboard/webapp/angular/BUILD | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tensorboard/webapp/angular/BUILD b/tensorboard/webapp/angular/BUILD index 66b8d71285..18d2e9e619 100644 --- a/tensorboard/webapp/angular/BUILD +++ b/tensorboard/webapp/angular/BUILD @@ -79,6 +79,15 @@ tf_ts_library( ) # This is a dummy rule used as a @angular/material/checkbox dependency. +tf_ts_library( + name = "expect_angular_material_checkbox", + srcs = [], + deps = [ + "@npm//@angular/material", + ], +) + +# This is a dummy rule used as a @angular/material/legeacy_checkbox dependency. tf_ts_library( name = "expect_angular_legacy_material_checkbox", srcs = [], From 9c043d243eb6dc3440480d85e3a141c55f2fc737 Mon Sep 17 00:00:00 2001 From: Riley Jones Date: Wed, 16 Aug 2023 20:47:10 +0000 Subject: [PATCH 4/5] add new testing rule cl/557590954 --- tensorboard/webapp/widgets/data_table/BUILD | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tensorboard/webapp/widgets/data_table/BUILD b/tensorboard/webapp/widgets/data_table/BUILD index 59f263a820..773be63f41 100644 --- a/tensorboard/webapp/widgets/data_table/BUILD +++ b/tensorboard/webapp/widgets/data_table/BUILD @@ -147,7 +147,7 @@ tf_ng_module( ], deps = [ ":types", - "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_material_checkbox", "//tensorboard/webapp/widgets/filter_input", "//tensorboard/webapp/widgets/range_input", "//tensorboard/webapp/widgets/range_input:types", @@ -182,6 +182,7 @@ tf_ts_library( "//tensorboard/webapp/angular:expect_angular_cdk_testing_testbed", "//tensorboard/webapp/angular:expect_angular_core_testing", "//tensorboard/webapp/angular:expect_angular_material_checkbox", + "//tensorboard/webapp/angular:expect_angular_material_checkbox_testing", "//tensorboard/webapp/angular:expect_angular_platform_browser_animations", "//tensorboard/webapp/testing:mat_icon", "//tensorboard/webapp/widgets/custom_modal", From 317e7331915e1a4b323cc35ff842e26971b6a0ea Mon Sep 17 00:00:00 2001 From: Riley Jones Date: Wed, 16 Aug 2023 21:38:51 +0000 Subject: [PATCH 5/5] add add dummy rule definition --- tensorboard/webapp/angular/BUILD | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tensorboard/webapp/angular/BUILD b/tensorboard/webapp/angular/BUILD index 18d2e9e619..239d36af58 100644 --- a/tensorboard/webapp/angular/BUILD +++ b/tensorboard/webapp/angular/BUILD @@ -96,6 +96,15 @@ tf_ts_library( ], ) +# This is a dummy rule used as a @angular/material/checkbox/testing dependency. +tf_ts_library( + name = "expect_angular_material_checkbox_testing", + srcs = [], + deps = [ + "@npm//@angular/material", + ], +) + # This is a dummy rule used as a @angular/material/button dependency. tf_ts_library( name = "expect_angular_material_button",