Upgrade handlebars 4.7.3 -> 4.7.6 to avoid optimist dep #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
approved these changes
Apr 14, 2020
psybuzz
approved these changes
Apr 14, 2020
Good point, but we're already pretty skewed (4.0.14 internally) so I figure a small amount more here is unlikely to cause issues. |
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our yarn.lock file to bump our
handlebarsdep from 4.7.3 to 4.7.6 (the latest available release), which I did just by deleting the old entry and rerunning yarn install. This addresses the easy part of #3516 by picking up handlebars-lang/handlebars.js#1658 to prune a transitive dependency viaoptimiston an old version ofminimist.