Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF Serving doesn't build with gcc 4.8.5 #1001

Closed
goswamig opened this issue Jul 18, 2018 · 7 comments
Closed

TF Serving doesn't build with gcc 4.8.5 #1001

goswamig opened this issue Jul 18, 2018 · 7 comments

Comments

@goswamig
Copy link

gcc version: 4.8.5

@netfs
Copy link
Collaborator

netfs commented Jul 18, 2018

can you upgrade to gcc 4.9. see nlohmann/json#109 for more details.

@goswamig
Copy link
Author

goswamig commented Jul 18, 2018

Is there anyway to bypass the unit test compilation ? We can't change the gcc version due to some other package requirement.

@netfs
Copy link
Collaborator

netfs commented Jul 19, 2018

if you control the compilation, you could certainly change the sources to skip the tests. i'd advise against that, as you would loose test coverage. short of that i am unsure what else could be done.

patches/contributions to make the current code work (also) on gcc 4.8.5 are welcome.

@gautamvasudevan
Copy link
Collaborator

Here's the error:
TF -serving (1.8 and 1.9) build from source failed with tensorflow_serving/util/json_tensor_test.cc:60:43: error: unterminated raw string

Retitiling for clarity.

@gautamvasudevan gautamvasudevan changed the title TF -serving (1.8 and 1.9) build from source failed with tensorflow_serving/util/json_tensor_test.cc:60:43: error: unterminated raw string TF Serving doesn't build with gcc 4.8.5 Jul 26, 2018
@sathyarr
Copy link

if you control the compilation, you could certainly change the sources to skip the tests. i'd advise against that, as you would loose test coverage. short of that i am unsure what else could be done.

patches/contributions to make the current code work (also) on gcc 4.8.5 are welcome.

By the way, how could I skip tests?

@pindinagesh pindinagesh self-assigned this Mar 30, 2022
@pindinagesh
Copy link

Hi @goswamig

Could you kindly check gcc with latest version of TF Serving and please have a look at this issue which is addressed already. Thanks!

@pindinagesh
Copy link

@goswamig

Closing this issue due to inactivity. Please feel free to reopen if this still exists. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants