Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure #258

Closed
xiangzez opened this issue Jun 30, 2022 · 1 comment · Fixed by #260
Closed

Build failure #258

xiangzez opened this issue Jun 30, 2022 · 1 comment · Fixed by #260
Assignees

Comments

@xiangzez
Copy link
Contributor

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
  • TensorFlow version and how it was installed (source or binary): binary
  • TensorFlow-Recommenders-Addons version and how it was installed (source or binary): source
  • Python version: 3.8.10
  • Is GPU used? (yes/no): no

Describe the bug

hiredis update redis/hiredis#1057 changes static lib name from libhiredis_static.a to libhiredis.a, causing build failture:

external/hiredis/BUILD.bazel:19:15: output 'external/hiredis/hiredis/lib/libhiredis_static.a' was not created

Need to update hiredis.BUILD or fix hiredis to older version in WORKSPACE.

Code to reproduce the issue

git clone https://github.com/tensorflow/recommenders-addons.git
cd recommenders-addons
python configure.py
bazel build --enable_runfiles build_pip_pkg
@rhdong
Copy link
Member

rhdong commented Jul 1, 2022

Hi @xiangzez , thank you for the feedback, we really met the issue. We will fix it soon. thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants