Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDFV==0.14.0 Wheel Fails Integrity Check #78

Closed
jhamet93 opened this issue Aug 12, 2019 · 8 comments
Closed

TDFV==0.14.0 Wheel Fails Integrity Check #78

jhamet93 opened this issue Aug 12, 2019 · 8 comments

Comments

@jhamet93
Copy link

jhamet93 commented Aug 12, 2019

It appears TFDV==0.14.0 has a bad hash value and is failing the integrity check done by the resolver, pex:

Exception message: Bad hash for file 'tensorflow_data_validation/pywrap/_pywrap_tensorflow_data_validation.so'.

It has been reported (pypa/pip#4705) that pip does not check the file hashes for integrity but other resolvers such as Pex do which leads to failures. Thus, it appears there's some mutation after the wheel is built ?

Minimal Repo:

pip install pex
pex tensorflow-data-validation==0.14.0 -o tfdv.pex
@gowthamkpr gowthamkpr self-assigned this Aug 12, 2019
@rmothukuru rmothukuru assigned rmothukuru and unassigned gowthamkpr Aug 13, 2019
@rmothukuru
Copy link

@jhamet93 ,
I have tried reproducing your issue with the Repro Code provided by you in Linux Terminal but I didn't get the Exception Message which you got.

Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow and version. Also, did you compile from source or install a binary?

Make sure you also include the exact command if possible to produce the output included in your test case. If you are unclear what to include see the issue template displayed in the Github new issue template.

We ask for this in the issue submission template, because it is really difficult to help without that information. Thanks!

@paulgc
Copy link
Member

paulgc commented Aug 13, 2019

We can verify that the wheel is failing the check by doing:

wheel unpack tensorflow_data_validation-0.14.0-cp27-cp27mu-manylinux2010_x86_64.whl

Unpacking to: ./tensorflow_data_validation-0.14.0...Hash mismatch for file 'tensorflow_data_validation/pywrap/_pywrap_tensorflow_data_validation.so'

@rmothukuru rmothukuru assigned paulgc and rmothukuru and unassigned rmothukuru Aug 14, 2019
@rmothukuru
Copy link

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

@jhamet93
Copy link
Author

@rmothukuru Sorry I did not respond. The comment above is a way to reproducing the issue at hand which is the package fails the integrity check because there's a modification after the wheel is built.

wheel unpack tensorflow_data_validation-0.14.0-cp27-cp27mu-manylinux2010_x86_64.whl

Unpacking to: ./tensorflow_data_validation-0.14.0...Hash mismatch for file 'tensorflow_data_validation/pywrap/_pywrap_tensorflow_data_validation.so'

@caveness
Copy link
Collaborator

Re-opening this issue. We have verified this failure and plan to have a 0.14.1 release out soon that will address it. We will close this bug when that release is out.

@caveness caveness reopened this Aug 20, 2019
@kwlzn
Copy link

kwlzn commented Aug 20, 2019

thanks a ton @caveness! this is blocking our adoption of TFDV at Twitter, so we're happy to help kick tires on a release candidate wheel binary if that would be useful before cutting to pypi - otherwise we'll keep an eye out for the next official release.

@paulgc
Copy link
Member

paulgc commented Aug 20, 2019

@kwlzn 0.14.1 should be out within the next few days.

@rmothukuru rmothukuru removed their assignment Aug 21, 2019
@paulgc
Copy link
Member

paulgc commented Aug 22, 2019

Closing this as 0.14.1 is released.

@kwlzn @jhamet93 Let us know if you face any other issues.

@paulgc paulgc closed this as completed Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants