Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Load Custom Ops #855

Closed
seanpmorgan opened this issue Jan 10, 2020 · 0 comments · Fixed by #869
Closed

Lazy Load Custom Ops #855

seanpmorgan opened this issue Jan 10, 2020 · 0 comments · Fixed by #869

Comments

@seanpmorgan
Copy link
Member

A major issue we have with Addons is that it is compatible with PyPi TensorFlow, but has ABI incompatibilities with TF that was built from source or installed with conda depending on the compiler and settings:
#676
#753
#574

The ultimate fix for this will be the ABI stable kernel and ops:
tensorflow/community#133

However, as a mitigation it may be worthwhile to lazy load custom-ops when they are used:
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/activations/gelu.py#L23

At the moment all custom-ops are loaded during init. Seeing as >80% of addons does not use a custom-op it is likely that many users are experiencing this issue even when they don't plan on using a custom op. This is certainly a hacky "fix" and doesn't solve the issue but I thought it was worth discussing as I feel this is a major issue regarding adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant