-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable convenient vscode debugging #1089
Conversation
Signed-off-by: Yilong Li <[email protected]>
5e444c3
to
1c0f229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dragonly, gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -22,6 +22,7 @@ vendor/ | |||
go.work | |||
|
|||
.vscode/* | |||
!.vscode/launch.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to add this special exclusion but use git add -f
to add the file and the result will be expected :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then the index only exists in the git database so other tools may not work XD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then the index only exists in the git database so other tools may not work XD.
I did not get this. Do you mean the current change is correct, but a more elegant way is to use git add -f
? @tisonkun
With this PR, we can debug a binary built with
make debug-local
in vscode easily.