Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support forward #1014

Merged
merged 2 commits into from
Oct 25, 2022
Merged

feat: Support forward #1014

merged 2 commits into from
Oct 25, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Oct 13, 2022

This PR is to add a new goroutine to forward the backend pod's ports to the local host port.

Close #958

Signed-off-by: Ce Gao [email protected]

@gaocegege gaocegege changed the title WIP feat: Support forward feat: Support forward Oct 25, 2022
@gaocegege gaocegege marked this pull request as ready for review October 25, 2022 01:42
@gaocegege
Copy link
Member Author

/assign @VoVAllen @kemingy

Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@muniu-bot
Copy link

muniu-bot bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy, VoVAllen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VoVAllen,gaocegege,kemingy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit ab9fe2c into tensorchord:main Oct 25, 2022
@gaocegege gaocegege deleted the forward branch October 25, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: Port forwarding in envd-server runner
3 participants