Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): Integrate with Flyte #541

Open
2 tasks done
gaocegege opened this issue Jul 4, 2022 · 6 comments
Open
2 tasks done

feat(integration): Integrate with Flyte #541

gaocegege opened this issue Jul 4, 2022 · 6 comments
Assignees
Labels
priority/2-medium 💛 type/enhancement 💭 type/feature-epic ⭕ Huge features that cannot be tracked in one issue

Comments

@gaocegege
Copy link
Member

gaocegege commented Jul 4, 2022

Description

flyteorg/flyte#2573

We can collaborate with flyte community to support custom python dependencies in flyte.

/cc @pingsutw


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@gaocegege gaocegege added the type/feature-epic ⭕ Huge features that cannot be tracked in one issue label Jul 4, 2022
@issuelabeler issuelabeler bot added the dependencies Pull requests that update a dependency file label Jul 4, 2022
@gaocegege gaocegege added priority/2-medium 💛 and removed type/enhancement 💭 dependencies Pull requests that update a dependency file labels Jul 4, 2022
@gaocegege
Copy link
Member Author

Ref #567 about how to support custom base image in envd.

@gaocegege
Copy link
Member Author

We propose to add a field image to base:

def build():
  base(image="flyter-base-image")
  install.python_packages...

@pingsutw Does it work for you?

@pingsutw
Copy link
Member

yup, that's what we want, LGTM, thanks.

@gaocegege
Copy link
Member Author

gaocegege commented Nov 3, 2022

Ref https://docs.google.com/document/d/17TGmcIQRW-4tFCadzkdXHGNR9QoMH0yOKfiQHMtSuuU/edit#

The proposal in flyte community about the integration between flyte and envd.

@gaocegege
Copy link
Member Author

The base image of Flyte may look like this.

FROM python:3.9-slim

WORKDIR /root
ENV VENV /opt/venv
ENV LANG C.UTF-8
ENV LC_ALL C.UTF-8
ENV PYTHONPATH /root

RUN apt-get update && apt-get install -y build-essential

# Install the AWS cli separately to prevent issues with boto being written over
RUN pip3 install awscli
# Similarly, if you're using GCP be sure to update this command to install gsutil
RUN curl -sSL https://sdk.cloud.google.com/ | bash
ENV PATH="$PATH:/root/google-cloud-sdk/bin"

ENV VENV /opt/venv
# Virtual environment
RUN python3 -m venv ${VENV}
ENV PATH="${VENV}/bin:$PATH"

# Install Python dependencies
RUN pip install flytekit

# This tag is supplied by the build script and will be used to determine the version
# when registering tasks, workflows, and launch plans
ARG tag
ENV FLYTE_INTERNAL_IMAGE $tag

@gaocegege
Copy link
Member Author

def build():
    base(language="python", image="kemingy/flyte_base")
    install.python_packages(["via"])

The build script should work with the new release v0.2.5-alpha.1

Please update the env: pip install --pre --upgrade envd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/2-medium 💛 type/enhancement 💭 type/feature-epic ⭕ Huge features that cannot be tracked in one issue
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants