Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): Support ubuntu 18.04 and so on #1131

Closed
gaocegege opened this issue Nov 1, 2022 · 5 comments
Closed

feat(lang): Support ubuntu 18.04 and so on #1131

gaocegege opened this issue Nov 1, 2022 · 5 comments

Comments

@gaocegege
Copy link
Member

Description

#1103


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@VoVAllen
Copy link
Member

VoVAllen commented Nov 4, 2022

verify size gap between 18.04 and 20.04

@kemingy kemingy self-assigned this Nov 10, 2022
@kemingy
Copy link
Member

kemingy commented Nov 10, 2022

I tried the following Dockerfile (based on https://github.com/zhuwenxing/envd_demo/blob/main/Dockerfile)

ARG version=22

FROM ubuntu:${version}.04

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

RUN apt-get update && apt-get install -y --no-install-recommends wget apt-transport-https gnupg ca-certificates build-essential && \
    wget --no-check-certificate -qO- "https://get.helm.sh/helm-v3.8.1-linux-amd64.tar.gz" | tar --strip-components=1 -xz -C /usr/local/bin linux-amd64/helm && \
    apt-get remove --purge -y && \
    rm -rf /var/lib/apt/lists/*
RUN apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get install -y tzdata
RUN apt-get -y update && apt-get -y install sudo && apt-get install python3.8 -y && \
	sudo apt-get update -y && sudo apt-get install -y python3.8-dbg

COPY requirements.txt /requirements.txt

RUN apt-get update && apt-get install -y python3-pip git vim --fix-missing && python3.8 -m pip install -U pip setuptools

RUN python3.8 -m pip install --no-cache-dir -r /requirements.txt

RUN wget https://go.dev/dl/go1.18.4.linux-amd64.tar.gz && tar -C /usr/local -xzf go1.18.4.linux-amd64.tar.gz
ENV PATH $PATH:/usr/local/go/bin

WORKDIR /root

Results:

REPOSITORY                          TAG                  IMAGE ID       CREATED              SIZE
pygo                                20                   3d20fbd5d23b   8 minutes ago        1.36GB
pygo                                18                   67ac85ccb2fb   14 minutes ago       1.4GB

Thus I don't think we should support 18.04. But maybe we can consider 22.04.

@kemingy
Copy link
Member

kemingy commented Nov 11, 2022

@gaocegege
Copy link
Member Author

SGTM

@kemingy
Copy link
Member

kemingy commented Dec 22, 2022

Close this due to syntax v1.

@kemingy kemingy closed this as completed Dec 22, 2022
@kemingy kemingy moved this to Done in envd sprint board Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants