Removed installing extra addons from afterInstall hook #14 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They kept removing our addon from the node_modules/
|
fyi this is related to an npm issue that removes modules installed via a git url. Down/Upgrading your npm version should fix this. As an alternative, I believe using docker-ember works fine :). See also npm/npm#17379 |
|
@nvdk Good find! We'll look into it. |
|
@lordblendi |
|
@asjongers We still need to look into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They kept removing our addon from the node_modules/. Hard to reproduce, on some computers it occurs, but not on everyone's machine. As a backup solution I removed them from the afterInstall hook and changed the readme.
Related issue: #14